Register forum user name Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.

Due to spam on this forum, all posts now need moderator approval.

 Entire forum ➜ MUSHclient ➜ Bug reports ➜ Commands not being logged

Commands not being logged

It is now over 60 days since the last post. This thread is closed.     Refresh page


Posted by Nick Gammon   Australia  (23,165 posts)  Bio   Forum Administrator
Date Thu 17 Apr 2003 01:12 AM (UTC)
Message
I am almost afraid to ask this, because I know it will kick up another storm, but here goes...

It seems that there is a bug in versions 3.36/3.37 where commands are not being logged. Now, the question is, if you type an alias, what do you expect to be logged (assuming you have a log file)?

* Nothing
* The alias you typed
* The command that the alias evaluated to (which actually got sent)
* Both

And, if the alias "omit from log" flag is set, what gets omitted?

* The alias you typed?
* The command that is sent?
* Both?

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Vaejor   (120 posts)  Bio
Date Reply #1 on Thu 17 Apr 2003 01:33 AM (UTC)
Message
The most basic answer seems to be: anything that appears on the screen should be logged unless it's specifically marked to omit from log(triggers/aliases)
Top

Posted by Nick Gammon   Australia  (23,165 posts)  Bio   Forum Administrator
Date Reply #2 on Thu 17 Apr 2003 01:53 AM (UTC)
Message
OK, if we go with that basic definition, why would someone want to set "omit from log" for an alias?

If the logging is a record of the session, they can already choose whether or not commands, in general, are logged. Why would you want to selectively omit a command from the log?

In version 3.34 and earlier, what appeared to be logged was the evaluated text (ie. what the alias sent) not the alias itself. It seems to me that a more accurate record of what you did would be to log what you typed, not necessarily what got sent.

Here is a proposal - what about having this as a rule:

If logging is on AND
If "logging commands" is on THEN ...


  • If you type a simple command it is logged.
  • If you type an alias and "echo alias" is on, the alias is logged (ie. what you actually typed).
  • If you type an alias and the alias "omit from log" is not on, the alias *output* is logged.


- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Vaejor   (120 posts)  Bio
Date Reply #3 on Thu 17 Apr 2003 02:41 AM (UTC)
Message
I'd agree with that logic.
Top

Posted by Nick Gammon   Australia  (23,165 posts)  Bio   Forum Administrator
Date Reply #4 on Thu 17 Apr 2003 07:45 AM (UTC)
Message
Version 3.38 does it that way.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.


16,660 views.

It is now over 60 days since the last post. This thread is closed.     Refresh page

Go to topic:           Search the forum


[Go to top] top

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.