[Home] [Downloads] [Search] [Help/forum]

Gammon Forum

See www.mushclient.com/spam for dealing with forum spam. Please read the MUSHclient FAQ!

[Folder]  Entire forum
-> [Folder]  MUSHclient
. -> [Folder]  Bug reports
. . -> [Subject]  Ctrl+S doesn't clear dirty flag.
Home  |  Users  |  Search  |  FAQ
Username:
Register forum user name
Password:
Forgotten password?

Ctrl+S doesn't clear dirty flag.

It is now over 60 days since the last post. This thread is closed.     [Refresh] Refresh page


Posted by WillFa   USA  (525 posts)  [Biography] bio
Date Wed 07 Jul 2010 08:22 AM (UTC)

Amended on Wed 07 Jul 2010 08:33 AM (UTC) by WillFa

Message
Press Ctrl+S to save your world. Press Ctrl+F4 immediately afterwards to close the world. You'll still get prompted that "Variables only have changed. Would you like to save?"

"I just did!"


(This still happens on 4.52)
[Go to top] top

Posted by Nick Gammon   Australia  (21,322 posts)  [Biography] bio   Forum Administrator
Date Reply #1 on Wed 07 Jul 2010 09:57 PM (UTC)
Message
Can't reproduce that. Are you sure that the saving process doesn't change things? For example if the "on save" handler changed a variable, then it might become dirty again.

Or a timer might fire in the short interval after you saved it, and changed something.

Try doing a save, renaming the saved world file, then closing and accepting the offer to save again, then do a diff to see what changes there are between the two files.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top

Posted by Twisol   USA  (2,257 posts)  [Biography] bio
Date Reply #2 on Wed 07 Jul 2010 09:58 PM (UTC)
Message
Nick Gammon said:
For example if the "on save" handler changed a variable, then it might become dirty again.

That seems fishy. Shouldn't the client only save -after- the on-save handlers are called?

'Soludra' on Achaea

Blog: http://jonathan.com/
GitHub: http://github.com/Twisol
[Go to top] top

Posted by Nick Gammon   Australia  (21,322 posts)  [Biography] bio   Forum Administrator
Date Reply #3 on Wed 07 Jul 2010 10:25 PM (UTC)
Message
Lol - the flag that said that the variables have changed was never cleared. Thus, once you change a variable it *always* asked you to save the world. I must admit that had niggled at the back of my brain for a while.

Fixed in version 4.53.

The reason is, it used to just set the "dirty" flag - which the OnSave cleared. However once it set its own "variables have changed" flag, this was never cleared, due to a small oversight.

No-one else noticed this either *cough* Twisol *cough*.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top

Posted by Twisol   USA  (2,257 posts)  [Biography] bio
Date Reply #4 on Wed 07 Jul 2010 10:29 PM (UTC)
Message
Pah! I was focused elsewhere. >_>

(Speaking of which, I have a couple other fixes you can expect later!)

'Soludra' on Achaea

Blog: http://jonathan.com/
GitHub: http://github.com/Twisol
[Go to top] top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.


3,519 views.

It is now over 60 days since the last post. This thread is closed.     [Refresh] Refresh page

Go to topic:           Search the forum


[Go to top] top

Quick links: MUSHclient. MUSHclient help. Forum shortcuts. Posting templates. Lua modules. Lua documentation.

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.

[Home]


Written by Nick Gammon - 5K   profile for Nick Gammon on Stack Exchange, a network of free, community-driven Q&A sites   Marriage equality

Comments to: Gammon Software support
[RH click to get RSS URL] Forum RSS feed ( https://gammon.com.au/rss/forum.xml )

[Best viewed with any browser - 2K]    [Hosted at FutureQuest]