[Home] [Downloads] [Search] [Help/forum]

Gammon Forum

See www.mushclient.com/spam for dealing with forum spam. Please read the MUSHclient FAQ!

[Folder]  Entire forum
-> [Folder]  MUSHclient
. -> [Folder]  Bug reports
. . -> [Subject]  Data ordering problem in AnsiNote in callbacks (gmcp)
Home  |  Users  |  Search  |  FAQ
Username:
Register forum user name
Password:
Forgotten password?

Data ordering problem in AnsiNote in callbacks (gmcp)

It is now over 60 days since the last post. This thread is closed.     [Refresh] Refresh page


Pages: 1  2 

Posted by Fiendish   USA  (1,641 posts)  [Biography] bio   Global Moderator
Date Reply #15 on Sun 11 Dec 2016 09:13 PM (UTC)
Message
It seemed to work in testing on Windows 10.
I can't figure out how to make Visual Studio Community 2015 build an executable that works in XP or Wine as a drop-in .exe replacement no matter what project settings I poke at.

https://github.com/fiendish/aardwolfclientpackage
[Go to top] top

Posted by Nick Gammon   Australia  (21,322 posts)  [Biography] bio   Forum Administrator
Date Reply #16 on Mon 12 Dec 2016 04:51 AM (UTC)
Message
You mean, it won't compile, or it compiles and works under Windows 10 but not Windows XP?

- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top

Posted by Fiendish   USA  (1,641 posts)  [Biography] bio   Global Moderator
Date Reply #17 on Mon 12 Dec 2016 10:09 AM (UTC)
Message
I can compile it no problem and it works in Windows 10 without changes.
But I haven't yet produced an executable that runs in XP without also transporting a bunch of extra DLLs along with it.

https://github.com/fiendish/aardwolfclientpackage
[Go to top] top

Posted by Nick Gammon   Australia  (21,322 posts)  [Biography] bio   Forum Administrator
Date Reply #18 on Tue 13 Dec 2016 06:09 AM (UTC)
Message
I tried to compile, and it said (under XP) that it wasn't a valid Win32 application.

Ah well, that's Windows for you!

- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top

Posted by Nick Gammon   Australia  (21,322 posts)  [Biography] bio   Forum Administrator
Date Reply #19 on Wed 14 Dec 2016 02:07 AM (UTC)
Message
I'm a little surprised it worked for you without this change:

https://github.com/nickgammon/mushclient/commit/e7b539f

- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top

Posted by Fiendish   USA  (1,641 posts)  [Biography] bio   Global Moderator
Date Reply #20 on Wed 14 Dec 2016 10:26 AM (UTC)

Amended on Wed 14 Dec 2016 10:27 AM (UTC) by Fiendish

Message
Nick Gammon said:

I'm a little surprised it worked for you without this change:

https://github.com/nickgammon/mushclient/commit/e7b539f

O_o
Hah. Should I guess that this happened to you? It didn't happen to me. ^_^

https://github.com/fiendish/aardwolfclientpackage
[Go to top] top

Posted by Nick Gammon   Australia  (21,322 posts)  [Biography] bio   Forum Administrator
Date Reply #21 on Wed 14 Dec 2016 08:05 PM (UTC)
Message
I probably have a Note or similar in a plugin, outside any function (in my default testing world). That would be called early in the program startup sequence, before the main output window is created.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top

Posted by Fiendish   USA  (1,641 posts)  [Biography] bio   Global Moderator
Date Reply #22 on Sat 17 Dec 2016 01:16 PM (UTC)

Amended on Sat 17 Dec 2016 01:26 PM (UTC) by Fiendish

Message
Nick Gammon said:


-- Subnegotiations go back in just before the EOL so they
-- get processed by MUSHclient in the right sequence.


I think you'll have to change that to "just after" so that they occur at the start of a line, not the end of the previous one.


Hehe. You might be interested, my current iterations on that project are:
https://raw.githubusercontent.com/fiendish/aardwolfclientpackage/development/MUSHclient/worlds/plugins/text_substitution.xml
https://raw.githubusercontent.com/fiendish/aardwolfclientpackage/development/MUSHclient/worlds/plugins/simplified_text_substitution.xml

The first filters both main output and GMCP comm.channel.msg in OnPluginPacketReceived.
The second does only main output via a maximum priority catchall trigger and lets other plugins opt-in with CallPlugin("48f867c18f6ff1d6d3b52918", "filter_string", msg)
Both are still in testing. I expect some fragility. [1]

I'm thinking about doing a third one, which is the middle ground between the two, that does GMCP comm.channel.msg in OnPluginPacketReceived and main output with a trigger.

[1] - e.g. I just got a report from a tester using the first one of the following error. Could be coincidence, could be not. :
GMCP DATA ERROR: C:\awmcd\MUSHclient\lua\json\decode\util.lua:35: 
unexpected character @ character: 11 0:11 ["] line:
{ "name": "
\\;ndo", "class": "Thief", "subclass": "Assassin", "race": "Dark elf", 
"clan": "boot", "pretitle": "", "perlevel": 2000, "tier": 0, "remorts": 0, 
"redos": "0" }

https://github.com/fiendish/aardwolfclientpackage
[Go to top] top

Posted by Nick Gammon   Australia  (21,322 posts)  [Biography] bio   Forum Administrator
Date Reply #23 on Sat 17 Dec 2016 08:58 PM (UTC)
Message
Perhaps we are seeing why MUSHclient doesn't automagically allow substitutions inside the incoming text. It's hard to get right.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top

Posted by Fiendish   USA  (1,641 posts)  [Biography] bio   Global Moderator
Date Reply #24 on Sat 17 Dec 2016 11:48 PM (UTC)
Message
Nick Gammon said:

Perhaps we are seeing why MUSHclient doesn't automagically allow substitutions inside the incoming text. It's hard to get right.

Ehhhhh...we're pretty smart. I bet other things are harder.

https://github.com/fiendish/aardwolfclientpackage
[Go to top] top

Posted by Nick Gammon   Australia  (21,322 posts)  [Biography] bio   Forum Administrator
Date Reply #25 on Sun 18 Dec 2016 03:13 AM (UTC)
Message
What, like world peace?

- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top

Posted by Fiendish   USA  (1,641 posts)  [Biography] bio   Global Moderator
Date Reply #26 on Mon 19 Dec 2016 02:14 PM (UTC)

Amended on Mon 19 Dec 2016 05:51 PM (UTC) by Fiendish

Message
Nick Gammon said:

What, like world peace?

Nah, basic gagging/replacement code isn't actually that hard. I've chosen to complicate things somewhat by allowing for gsub-like patterns, color codes and resets, and external functions for conditional replacements through a proxied CallPlugin interface. Because why do something simple when you can do something awesome?

Actually the only reason why I still don't have the simplified version fully working yet is because of having to work within MUSHclient's triggering framework (I keep failing to reliably conditionally omit, halt trigger evaluation, and also simulate, while working together with other plugins that also want to simulate).

https://github.com/fiendish/aardwolfclientpackage
[Go to top] top

Posted by Fiendish   USA  (1,641 posts)  [Biography] bio   Global Moderator
Date Reply #27 on Mon 19 Dec 2016 05:52 PM (UTC)
Message
Fiendish said:

Nick Gammon said:

What, like world peace?

Nah, basic gagging/replacement code isn't actually that hard. I've chosen to complicate things somewhat by allowing for gsub-like patterns, color codes and resets, and external functions for conditional replacements through a proxied CallPlugin interface. Because why do something simple when you can do something awesome?

Actually the only reason why I still don't have the simplified version fully working yet is because of having to work within MUSHclient's triggering framework (I keep failing to reliably conditionally omit, halt trigger evaluation, and also simulate, while working together with other plugins that also want to simulate).


Though I think I have all the kinks worked out now pending the fix for dangling styles.

https://github.com/fiendish/aardwolfclientpackage
[Go to top] top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.


5,790 views.

This is page 2, subject is 2 pages long:  [Previous page]  1  2 

It is now over 60 days since the last post. This thread is closed.     [Refresh] Refresh page

Go to topic:           Search the forum


[Go to top] top

Quick links: MUSHclient. MUSHclient help. Forum shortcuts. Posting templates. Lua modules. Lua documentation.

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.

[Home]


Written by Nick Gammon - 5K   profile for Nick Gammon on Stack Exchange, a network of free, community-driven Q&A sites   Marriage equality

Comments to: Gammon Software support
[RH click to get RSS URL] Forum RSS feed ( https://gammon.com.au/rss/forum.xml )

[Best viewed with any browser - 2K]    [Hosted at FutureQuest]