MouseDown Problems. Baffled. (Python)

I'm toying around with hotspots, and I managed to get a button working just fine.

Then I decided I needed another button. Which also works.
Except for one thing.

I want my buttons to draw a different image on MouseDown, so it shows you're clicking on it. This worked just fine in my first version, but doesn't now.

Which is already weird, since my code hasn't changed.

However, it gets weirder.

When adding a world.Note to the function that handles the drawing of the 'clicked' image, it works. Splendidly. Deleting that world.Note reverses everything to its problematic state.

I'm baffled, as I have absolutely no idea what causes this.

I'm no Python expert, but can you post the function in its working and not-working version (the part that handles the mousedown).

Isn't Python very spacing-conscious? Maybe by adding an extra line you changed the way it handled the function.

Also I would check the return code from the line that draws the image - if a drawing function fails it generally returns a non-zero error code.

Adding an empty line doesn't solve the problem, unfortunately. Empty lines generally don't do much in Python, spaces do, and those are all fine.


This function doesn't work:



This one does:



This function is called as the hotspot "mousedown" handler, just so you know, though I don't see how that would change anything.

Loot_ButtonClicked() calls the following:



It's definately not a drawing error. I don't even get an error, it just, you know, fails to work.

I'm going to try different names, maybe Python won't accept the current ones or something strange...

Edit:: my spacing seems to be off in this example, this is not the case in the actual code though.
Edit2:: added the code for Loot_ButtonClicked()

Is this code in a plugin? Hotspots only work in plugins.



See:



That returns a non-zero code if it fails. You could test that code and display a message if it is not zero. That at least eliminates that possibility.

eg.



(or however you do it in Python).

However I can't really explain it. Maybe the Python experts here can.

This code is entirely in a plugin. Error checking gives a zero, so no drawing error. Changing names didn't work either. For the moment, I'm stuck with adding an empty line via world.Note, but it's not aesthetically pleasing >.>

Next I'll try to work with one mousedown function with ifs for different hotspot_ids. Maybe that'll work.

Edit:: It didn't. However, I noticed that it does react to double-clicking. Checking my code now, maybe I'll find something. And if not, maybe I can code a solution now.

Edit2:: Bah. Stupid me. Somehow I managed to delete the WindowShow function that was supposed to be called. I still think it behaved weird, but at least now it works. Thanks for the help.

Try adding a world.WindowShow("name") and a world.Repaint() to the function.

If WindowDrawImage follows with the other Window functions, you're actually manipulating a buffer and not the region of the screen itself. You'd need the WindowShow to "apply" the changes. After the changes are applied, they don't appear until the screen gets redrawn -- for example from a world.Note() or incoming text from the mud. Repaint should force an update.

WindowShow should be enough. The repaint happens quite quickly, next time through the main event loop (unless there are other higher-priority events, like mouseclicks there). Getting into the habit of putting Repaint everywhere will slow the program down for no noticeable improvement.




It is quite valid to draw to offscreen windows, so automatically repainting the onscreen ones just because you draw an image would add an overhead that might not be justified.

BTW, had you simply covered the MUSHclient window up (eg. with a notepad) and uncovered it, that should have forced a repaint, making it more obvious that the problem was not some bizarre script issue, but that the window was not being redrawn.

See this comment under WindowShow:

I have amended the help file for the next version to make it more obvious that you need to call Redraw after changing a miniwindow's contents.

Those documentation changes have now been applied to the online documentation here. For example:

WindowShow() works splendidly. It was really a dumb error on my part. Because both double-clicking and adding a world.Note seemed to force the window to be redrawn, I just thought there was way more behind this than there actually is.

Thanks for all the help, guys. You must have way too much patience...